Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-native-url-polyfill instead of deprecated url.parse in url-parser-native #2138

Closed
trivikr opened this issue Mar 16, 2021 · 3 comments · Fixed by #2229
Closed

Use react-native-url-polyfill instead of deprecated url.parse in url-parser-native #2138

trivikr opened this issue Mar 16, 2021 · 3 comments · Fixed by #2229
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Mar 16, 2021

Is your feature request related to a problem? Please describe.

Deprecated url.parse() is used in url-parser-native

import { parse } from "url";

Describe the solution you'd like

Use react-native-url-polyfill which is recommended in favor of implementation of URL polyfill in react-native facebook/react-native#25719 (comment)

Describe alternatives you've considered

Stick with deprecated url.parse() as it's not runtime deprecated yet.

@trivikr trivikr added the feature-request New feature or enhancement. May require GitHub community feedback. label Mar 16, 2021
@G-Rath
Copy link

G-Rath commented Mar 18, 2021

Could this please done in the same manner as recommended for react-native-get-random-values in #2108?

Otherwise npm@7 will pull react-native in due to react-native-url-polyfill having it as a peerDependency, which is not desirable for devs that are not actually using react-native, as it's big and has unpatchable vulnerabilities :)

(Maybe an @aws-sdk/utils-react-native-polyfils package could be a good idea, that has all of these and does the requiring, so you could say to folks "if you're on react-native, install and require this extra package").

@trivikr
Copy link
Member Author

trivikr commented Mar 26, 2021

Created an issue upstream to make react-native peerDependency optional charpeni/react-native-url-polyfill#269

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants