feat(middleware-bucket-endpoint): add object lambda support #2143
Conversation
|
Looks like there is something up with smithy's 1.7.0 release. Ignore codegen-ci for now |
| accelerateEndpoint: true, | ||
| }); | ||
| // should never get here | ||
| expect(1).toEqual(0); |
There was a problem hiding this comment.
Nit: this won't provide very useful error message, you can validate exactly 1 assertion is called by expect.assertions(1);. Same to other unit tests.
There was a problem hiding this comment.
ahh TIL. I'll update
There was a problem hiding this comment.
Not entirely sure how to replace this with expect.assertion() since this expect shouldn't ever be called here to begin with. I'm thinking possibly change the error message? Maybe something like:
expect("This configuration is invalid and should never get to this line").toEqual(0);
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Issue number, if available, prefixed with "#"
Description
Adding object lambda support with large number of unit tests.
Testing
E2e testing internally. unit tests here.
Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.