Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: set up greenkeeper for package updates #234

Closed
trivikr opened this issue May 1, 2019 · 6 comments
Closed

suggestion: set up greenkeeper for package updates #234

trivikr opened this issue May 1, 2019 · 6 comments

Comments

@trivikr
Copy link
Member

trivikr commented May 1, 2019

Greenkeeper is a really good tool for automated dependency management.
We use it in fastify packages, and it's pretty helpful.

It can be set up once existing dependencies are updated.
Greenkeeper will take up task of updating dependencies (like lerna in PR #233 for example)

@AllanZhengYP
Copy link
Contributor

@trivikr This is helpful. I think using it is much better than without this tool. A caveat is that most of our dependies lies in the dev dependencies which would only be used at release or doing code gen, we may not cover them in our github CI script and their breaking change may still break our release.

@AllanZhengYP
Copy link
Contributor

@trivikr I'm going to setup the Greenkeeper. Do you think free version is enough for now?

@trivikr
Copy link
Member Author

trivikr commented May 10, 2019

We were pending updating of Jest from v20->v24 prior to using greenkeeper
Jest was updated in #243

@trivikr
Copy link
Member Author

trivikr commented May 10, 2019

The first PR to enable greenkeeper is at #248

@trivikr
Copy link
Member Author

trivikr commented May 21, 2019

Closing as greenkeeper was set up in #248, and has posted update PRs since then (example #252)

@trivikr trivikr closed this as completed May 21, 2019
@lock
Copy link

lock bot commented Jun 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants