Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware-retry): add Adaptive Retry Strategy #2454

Merged
merged 10 commits into from
Jun 1, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 1, 2021

Issue

Internal JS-2634

Description

Add Adaptive Retry Strategy.

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@8ef104d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 878c617 differs from pull request most recent head 4cd2e0d. Consider uploading reports for the commit 4cd2e0d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2454   +/-   ##
=======================================
  Coverage        ?   59.24%           
=======================================
  Files           ?      493           
  Lines           ?    26326           
  Branches        ?     6247           
=======================================
  Hits            ?    15598           
  Misses          ?    10728           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef104d...4cd2e0d. Read the comment docs.

$ madge --warning --circular --extensions js dist/cjs/
Processed 12 files (426ms)

✖ Found 2 circular dependencies!

1) AdaptiveRetryStrategy.js > StandardRetryStrategy.js > configurations.js
2) StandardRetryStrategy.js > configurations.js
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. 🚢

@trivikr trivikr merged commit 0c9a143 into aws:main Jun 1, 2021
@trivikr trivikr deleted the retry-stretegy-adaptive branch June 1, 2021 22:12
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants