Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol_tests): format files using prettier v2.3.0 #2467

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 6, 2021

Issue

Refs: #2464

Description

The protocol_tests were mistakenly formatted using prettier v2.2.1 in the workspace for PR #2464
The prettier version was bumped to v2.3.0 in #2444

Testing

Verified the prettier v2.3.0 was installed before running yarn generate-clients as follows:

$ ./node_modules/.bin/prettier --version
2.3.0

Verified that prettier formatting for protocol_tests is same as that in #2444


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@72cc2dc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2467   +/-   ##
=======================================
  Coverage        ?   59.54%           
=======================================
  Files           ?      493           
  Lines           ?    26357           
  Branches        ?     6261           
=======================================
  Hits            ?    15695           
  Misses          ?    10662           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cc2dc...09c540f. Read the comment docs.

@trivikr trivikr merged commit cce6231 into aws:main Jun 6, 2021
@trivikr trivikr deleted the fix-prettier-formatting branch June 6, 2021 23:31
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants