Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3-request-presigner): remove x-amz-user-agent header #2493

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Issue

Resolves: #2383

Description

Remove x-amz-user-agent header when presign the request.

Testing

Unit test & manual test with S3 GET and PUT request


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP changed the title feat(s3-request-presigner): remove x-amz-user-agent header fix(s3-request-presigner): remove x-amz-user-agent header Jun 17, 2021
@AllanZhengYP AllanZhengYP merged commit 019292b into aws:main Jun 17, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@5e0a46a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2493   +/-   ##
=======================================
  Coverage        ?   59.55%           
=======================================
  Files           ?      493           
  Lines           ?    26370           
  Branches        ?     6265           
=======================================
  Hits            ?    15704           
  Misses          ?    10666           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0a46a...4ce226b. Read the comment docs.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to prevent SDK leaking host information to AWS?
4 participants