Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smithy-client): use uppercase for percent encodings #2500

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 18, 2021

Issue

Refs: #2499 (comment)

Description

Use uppercase for percent encodings

As per rfc3986 section 2.1, it should be "%2A"

The uppercase hexadecimal digits 'A' through 'F' are equivalent to
the lowercase digits 'a' through 'f', respectively. If two URIs
differ only in the case of hexadecimal digits used in percent-encoded
octets, they are equivalent. For consistency, URI producers and
normalizers should use uppercase hexadecimal digits for all percent-
encodings.

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore: use toUpperCase in extendedEncodeURIComponent fix(smithy-client): use uppercase for percent encodings Jun 18, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@122c139). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage        ?   59.56%           
=======================================
  Files           ?      494           
  Lines           ?    26377           
  Branches        ?     6265           
=======================================
  Hits            ?    15711           
  Misses          ?    10666           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 122c139...af9fdbd. Read the comment docs.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@trivikr trivikr merged commit 6ef34b5 into aws:main Jun 18, 2021
@trivikr trivikr deleted the encode-uppercase-hexadecimal branch June 18, 2021 16:04
@github-actions
Copy link

github-actions bot commented Jul 3, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants