Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add npm badges for individual packages #251

Merged
merged 7 commits into from
May 21, 2019
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 16, 2019

Issue #, if available:
N/A

Description of changes:
Adds npm badges showing version and downloads
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

command run from packages folder:
for d in ./*/ ; do (cd "$d" && [[ ! -f README.md ]] && echo # `basename $PWD` > README.md); done
following command was run from packages folder:
for d in ./*/ ; do
  (
    cd "$d"
    PACKAGE_NAME=@aws-sdk/`basename $PWD`
    echo '
[![NPM version](https://img.shields.io/npm/v/'$PACKAGE_NAME'.svg)](https://www.npmjs.com/package/'$PACKAGE_NAME')
[![NPM downloads](https://img.shields.io/npm/dm/'$PACKAGE_NAME'.svg)](https://www.npmjs.com/package/'$PACKAGE_NAME')' >> README.md
  );
done
Following code was run in packages folder:
for d in ./*/ ; do
  (
    cd "$d"
    PACKAGE_NAME=`basename "$PWD"`
    sed -ie "s/# $PACKAGE_NAME/# @AWS-SDK\/$PACKAGE_NAME/" README.md
  )
done
@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         265      265           
  Lines        6068     6068           
  Branches     1364     1364           
=======================================
  Hits         5545     5545           
  Misses        523      523
Impacted Files Coverage Δ
...ckages/service-types-generator/src/clientReadme.ts 36.55% <ø> (ø) ⬆️
packages/package-generator/src/ModuleGenerator.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1267e8...65c3c7e. Read the comment docs.

@trivikr trivikr merged commit 8adc10c into aws:master May 21, 2019
@trivikr trivikr deleted the npm-badge branch May 21, 2019 20:57
@lock
Copy link

lock bot commented Jun 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants