Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-transcribe-streaming): disable concurrent streams in handler #2563

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Resolves: #2555

Description

Sets Transcribe Streaming client H/2 handler to create new session for every new request. Previously it doesn't work for concurrent stream on 1 session, possibly due to server-side limitation.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 4476e55
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr changed the title fix(transcirbe-streaming): set max concurrency to 1 fix(client-transcribe-streaming): set max concurrency to 1 Jul 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@9303bf7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2563   +/-   ##
=======================================
  Coverage        ?   60.31%           
=======================================
  Files           ?      513           
  Lines           ?    27377           
  Branches        ?     6582           
=======================================
  Hits            ?    16512           
  Misses          ?    10865           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9303bf7...4476e55. Read the comment docs.

@trivikr trivikr changed the title fix(client-transcribe-streaming): set max concurrency to 1 fix(client-transcribe-streaming): disableConcurrentStreams in NodeHttp2Handler Jul 9, 2021
@trivikr trivikr changed the title fix(client-transcribe-streaming): disableConcurrentStreams in NodeHttp2Handler fix(client-transcribe-streaming): disable concurrent streams in handler Jul 9, 2021
@AllanZhengYP AllanZhengYP merged commit fb42522 into aws:main Jul 9, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable concurrent streams while using NodeHttp2Handler in TranscribeStreamingClient
4 participants