Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): link in development ssdk common lib #2655

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

JordonPhillips
Copy link
Member

@JordonPhillips JordonPhillips commented Aug 10, 2021

Issue

Fixes CI failures in server-protocol-tests.
Example https://github.com/aws/aws-sdk-js-v3/pull/2654/checks?check_run_id=3291926075

Description

This links the ssdk common library before running the ssdk protocol tests.

Testing

Ran the steps myself, and also the CI here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore: link in development ssdk common lib fix(ci): link in development ssdk common lib Aug 10, 2021
@trivikr trivikr merged commit 4be9ec6 into aws:main Aug 10, 2021
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 9216855
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants