Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): modular endpoints resolution #2704

Merged
merged 15 commits into from
Aug 25, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 24, 2021

Issue

Internal JS-2773
Follow-up to #2701

Description

Makes endpoint resolution modular as follows:

  • Removes immutable variables.
  • Removes switch statements.
  • Calls regionInfo utility functions from @aws-sdk/config-resolver, and passes appropriate options.

Testing

Integration tests are successful:

$ yarn test:integration
 PASS  clients/client-transcribe-streaming/test/index.integ.spec.ts (31.631 s)
  TranscribeStream client
    ✓ should stream the transcript (28799 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        32.11 s
Ran all test suites.
Done in 32.76s.

$ yarn test:integration-legacy 
yarn run v1.22.11
$ cucumber-js --fail-fast
...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

150 scenarios (150 passed)
523 steps (523 passed)
1m35.810s
Done in 99.40s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@7c6a790). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2704   +/-   ##
=======================================
  Coverage        ?   61.30%           
=======================================
  Files           ?      535           
  Lines           ?    27442           
  Branches        ?     6698           
=======================================
  Hits            ?    16823           
  Misses          ?    10619           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6a790...a7c8c4c. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve this as a follow up to #2696

@trivikr trivikr merged commit 88de69b into aws:main Aug 25, 2021
@trivikr trivikr deleted the clients-get-region-info branch August 25, 2021 22:29
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants