Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware-sdk-rds): stop throw when source id key is optional #2770

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Sep 9, 2021

Issue

Resolves: #2762

Description

The ReplicationSourceIdentifier key in CreateDBCluster is optional. So the SDK should NOT throw if the key is not supplied. This change stop throwing the error.

Testing

Unit test


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #2770 (a482da5) into main (6e8ddd7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2770      +/-   ##
==========================================
- Coverage   60.12%   60.12%   -0.01%     
==========================================
  Files         548      548              
  Lines       28559    28556       -3     
  Branches     6990     6989       -1     
==========================================
- Hits        17172    17170       -2     
+ Misses      11387    11386       -1     
Impacted Files Coverage Δ
packages/middleware-sdk-rds/src/index.ts 91.66% <100.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8ddd7...a482da5. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit 299cbbb into aws:main Sep 10, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDS Create DB Cluster required random source identifier
3 participants