fix(base64): validate base64 strings #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the node and browser base64 parsers to validate the input string before parsing.
JordonPhillips
force-pushed
the
validate-base64-padding
branch
from
fe993e1
to
4874c8a
Compare
adamthom-amzn
approved these changes
Sep 13, 2021
trivikr
approved these changes
Sep 13, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
This updates the node and browser base64 parsers to validate the input string before parsing.
Node previously would just ignore invalid characters and treat padding as optional. The browser implementation required padding, but had a bug where invalid characters were treated as 0.
Testing
Additional unit tests were added.
Additional context
n/a
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.