fix(scripts): do not destructure function parameter #2891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #2890
Description
Stores output of
fsPromises.stat
in a variable before calling.isDirectory()
on it.This changes sum of unpacked npm publish sizes for all packages from 456.40 MB to 411.28 MB (reduction of
~10%
).Code used for measuring npm unpacked publish size
Before
After
Testing
Verified that comments are removed from downlevel-dts files:
Before: comments are present in downlevel-dts
After: comments are not present in downlevel-dts files
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.