Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): export folder from index.ts #2912

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 18, 2021

Issue

Refs: smithy-lang/smithy-typescript#455

Description

Export folders from index.ts

Testing

  • CI
  • yarn test:integration
  • yarn test:integration-legacy

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review October 18, 2021 22:19
@codecov-commenter
Copy link

Codecov Report

Merging #2912 (08e1b57) into main (0a75f12) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2912   +/-   ##
=======================================
  Coverage   58.57%   58.57%           
=======================================
  Files         558      558           
  Lines       30249    30249           
  Branches     7443     7443           
=======================================
  Hits        17719    17719           
  Misses      12530    12530           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a75f12...08e1b57. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This saves a lot of bytes!
It doesn't, but the index is cleaner now

@trivikr trivikr merged commit 183b46d into aws:main Oct 20, 2021
@trivikr trivikr deleted the export-from-index branch October 20, 2021 21:31
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants