feat(client-nimble): change StudioComponentConfiguration from union to structure #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
… structure to union" This reverts commit 6be4874.
…guration to structure
Codecov Report
@@ Coverage Diff @@
## main #2971 +/- ##
=======================================
Coverage 58.70% 58.70%
=======================================
Files 566 566
Lines 30315 30315
Branches 7460 7460
=======================================
Hits 17796 17796
Misses 12519 12519 Continue to review full report at Codecov.
|
|
@kstich I have updated the implementation, and validated with the latest Nimble mode and make sure the shape remains a structure. |
kstich
approved these changes
Nov 3, 2021
AllanZhengYP
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add customization for Nimble service than change
StudioComponentConfigurationfrom structure shape to union shape.Additional context
ref: P54476166
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.