Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credential-providers): exclude node.js files for web #3006

Merged
merged 3 commits into from
Nov 11, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Nov 8, 2021

Description

Follow up to #3005. Correctly exclude node.js specific modules.

Related: AllanZhengYP#195


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as draft November 9, 2021 18:13
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #3006 (029a684) into main (e99f943) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3006   +/-   ##
=======================================
  Coverage   58.77%   58.77%           
=======================================
  Files         567      567           
  Lines       30366    30366           
  Branches     7484     7484           
=======================================
  Hits        17847    17847           
  Misses      12519    12519           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99f943...029a684. Read the comment docs.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review November 11, 2021 00:32
@AllanZhengYP AllanZhengYP requested a review from a team as a code owner November 11, 2021 00:32
@AllanZhengYP AllanZhengYP merged commit a890fd7 into aws:main Nov 11, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants