Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): use specific Smithy version #3011

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

adamthom-amzn
Copy link
Contributor

Description

This centralizes the Smithy version in the root Gradle file for ease of use,
and locks the CLI to the same Smithy version as the Smithy dependencies.

Testing

Built locally in combination with smithy-lang/smithy-typescript#465


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This centralizes the Smithy version in the root Gradle file for ease of use,
and locks the CLI to the same Smithy version as the Smithy dependencies.
@adamthom-amzn adamthom-amzn requested a review from a team as a code owner November 11, 2021 02:12
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑🇮🇹

@codecov-commenter
Copy link

Codecov Report

Merging #3011 (7f3b19b) into main (3bc91c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3011   +/-   ##
=======================================
  Coverage   58.76%   58.76%           
=======================================
  Files         567      567           
  Lines       30363    30363           
  Branches     7484     7484           
=======================================
  Hits        17844    17844           
  Misses      12519    12519           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc91c0...7f3b19b. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit 6cdee41 into aws:main Nov 11, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants