-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clients): update clients as of 2021/12/23 #3110
feat(clients): update clients as of 2021/12/23 #3110
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3110 +/- ##
=======================================
Coverage 58.72% 58.72%
=======================================
Files 572 572
Lines 30632 30632
Branches 7541 7541
=======================================
Hits 17990 17990
Misses 12642 12642
Continue to review full report at Codecov.
|
The unit test failure is a transient issue, and can be ignored. Summary of all failing tests
FAIL packages/signature-v4/src/SignatureV4.spec.ts (15.778 s)
● SignatureV4 › ambient Date usage › should use the current date for signing if no signing date supplied
expect(received).toBe(expected) // Object.is equality
Expected: "20211223T202358Z"
Received: "20211223T202357Z"
724 | it("should use the current date for signing if no signing date supplied", async () => {
725 | const { headers } = await signer.sign(minimalRequest);
> 726 | expect(headers[AMZ_DATE_HEADER]).toBe(iso8601(new Date()).replace(/[\-:]/g, ""));
| ^
727 | });
728 | });
729 | });
at src/SignatureV4.spec.ts:726:40
at step (src/SignatureV4.spec.ts:44:23)
at Object.next (src/SignatureV4.spec.ts:25:53)
at fulfilled (src/SignatureV4.spec.ts:16:58) A fix for this is attempted in #2880 |
Re-attempt succeeded in 9fd3720b-4387-44d7-b7ca-b5e5f222fd25 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Follow up to #3078
Description
Update clients as of 2021/12/23
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.