Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): generate clients in batches #3319

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 16, 2022

Issue

Internal JS-3071

Description

Generate clients in batches. The default batch size is 50, but a custom batch size can be specified using option -b or --batch-size

Time taken for building clients (the call for generateClients):

Batch Size Time taken
100 21.06s
50 27.68s
25 38.30s
10 70.62s

Testing

Verified that all clients are generated


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner February 16, 2022 06:14
@trivikr trivikr merged commit 2308e5f into aws:main Feb 16, 2022
@trivikr trivikr deleted the generate-clients-batches branch February 16, 2022 18:05
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants