feat(signature-v4-multi-region): support multi-region sigv4a signer #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(middleare-sdk-eventbridge): initial commit for eventbridge middleware * feat(signature-v3-cross-region): move S3 sigv4a signer to a new package * feat(middleware-sdk-eventbridge): implement inject endpointId mw * chore: generate S3 signer constroctor from new package * chore(eventbridge): add customization code generator * feat(s3-request-presigner): use cross region signer instead of s3 signer * feat(signature-v4-multiregion): rename signature-v4-cross-region to signature-v4-multiregion * fix(client-eventbridge): rename multi region to camel case Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
* chore: update ts version for new packages * feat(signature-v4-multi-region): update error messages
AllanZhengYP
force-pushed
the
event-bridge
branch
from
cbb7ea6
to
4e8604f
Compare
This reverts commit d049893.
trivikr
approved these changes
Apr 7, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
S3SignatureV4signer, which dynamically signs request with JavaScriptsignature-v4signer OR CRTsignature-v4-crtsigner, from themiddleware-sdk-s3package to a standalone packagesignature-v4-multi-region. So the new EventBridgeputEventsAPI can use the same signing method.middleware-sdk-eventbridgepackage that contains customization to modify theputEventsAPI endpoint. If theEndpointIdparameter exists, the endpoint will be modified to{EndpointId}.endpoint.events.{dnsSuffix}.Testing
Manual integration test; Unit test;
Automated integration test TBD
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.