fix(util-dynamodb): allow marshall function to handle more input types #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
previously approved these changes
Apr 14, 2022
kuhe
force-pushed
the
2807-lib-dynamodb-marshal
branch
from
b879c18
to
1105751
Compare
trivikr
reviewed
Apr 14, 2022
trivikr
approved these changes
Apr 21, 2022
AllanZhengYP
pushed a commit
that referenced
this pull request
Apr 22, 2022
AllanZhengYP
pushed a commit
that referenced
this pull request
Apr 22, 2022
AllanZhengYP
added a commit
that referenced
this pull request
Apr 22, 2022
keithalpichi
pushed a commit
to keithalpichi/aws-sdk-js-v3
that referenced
this pull request
Apr 23, 2022
aws#3539) * fix(util-dynamodb): allow marshall function to handle more input types * fix(util-dynamodb): revert marshall.spec.ts and minor formatting * fix(util-dynamodb): code spacing
keithalpichi
pushed a commit
to keithalpichi/aws-sdk-js-v3
that referenced
this pull request
Apr 23, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2807
Description
marshallmethod in util-dynamodb and used by lib-dynamodbMproperty assuming a map is the inputprocessObjin lib-dynamodb needs to accept falsy values other than undef.Testing
added unit/integration specs to cover the cases described in the issue and my other change to lib-dynamodb
Additional context
util-dynamodbis an internal package providing the marshaling functionality.lib-dynamodbis a wrapper forclient-dynamodbthat aims to simplify the object structure to one that is more JavaScript-like.