fix(codegen): check javascript property validity for property access #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
May 27, 2022
|
|
||
| import java.util.regex.Pattern; | ||
|
|
||
| public final class PropertyAccessor { |
There was a problem hiding this comment.
this should be moved to smithy-typescript since it is not SDK specific... later?
trivikr
reviewed
May 27, 2022
...degen/src/main/java/software/amazon/smithy/aws/typescript/codegen/JsonShapeDeserVisitor.java
Outdated
Show resolved
Hide resolved
...degen/src/main/java/software/amazon/smithy/aws/typescript/codegen/JsonShapeDeserVisitor.java
Outdated
Show resolved
Hide resolved
...main/java/software/amazon/smithy/aws/typescript/codegen/propertyaccess/PropertyAccessor.java
Outdated
Show resolved
Hide resolved
trivikr
approved these changes
May 27, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal P64934837
Description
.propand['prop']access modes.Testing
yarn generate-clientsusing the unreleased smithy model (not shown here)