Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(smithy-client): allow unambiguous type conversions in parse-utils #3888

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Aug 29, 2022

Issue

internal P70766077

Description

  • allow unambiguous type conversions instead of throwing
  • e.g. expectNumber("5") gives 5 with warning instead of throwing "5" is not a number.
  • e.g. expectString(5) gives "5" with warning instead of throwing 5 is not a string.

Testing

unit tests updated

@kuhe kuhe added the pr/needs-review This PR needs a review from a Member. label Aug 29, 2022
@kuhe kuhe requested a review from a team as a code owner August 29, 2022 21:10
@kuhe kuhe merged commit 967eb0a into aws:main Aug 30, 2022
@kuhe kuhe deleted the fix/expect-types branch August 30, 2022 18:18
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr/needs-review This PR needs a review from a Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants