fix(types): declare ReadableStream type without requiring dom #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
approved these changes
Aug 30, 2022
|
Hi @AllanZhengYP, this didn't fix #2522. The error was a runtime error due to ReadableStream not being defined on the global object on Nodejs. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves: #3807
Resolves: #3063
Resolves: #2522
#2896 will be fixed in follow-up PR with similar fix.
Description
The SDK clients have reference to
ReadableStreaminterface only available indom. It causes building issue for users that don't have dependency overdom. This is a minimal fix to eliminateerror TS2304: Cannot find name 'ReadableStream'. How it works is decribed in microsoft/TypeScript#31894.Testing
Manual test with repro:
#3063 (comment)
Additional context
This can be removed when TypeScript comes up with solution that supports runtime-specific types.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.