fix(e2e): fix "eventually" helper in e2e tests #3917
Conversation
| @@ -40,16 +40,15 @@ module.exports = { | |||
| if (!options.backoff) options.backoff = 500; | |||
| if (!options.maxTime) options.maxTime = 5; | |||
|
|
|||
| const delay = options.delay; | |||
There was a problem hiding this comment.
This function has likely been broken for a very long time. delay += options.backoff; could never have worked with const delay. It's likely the AWS.util.date.getDate() call did not return a reasonable value and the retry did not happen, meaning previously passing e2e tests always succeeded on the first try of the next.condition.
There was a problem hiding this comment.
The AWS.util.date.getDate() is a remnant from AWS SDK for JavaScript (v2), which wouldn't have worked in v3. We would have missed removing it when migrating integration tests.
Thanks for catching it!
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Description
Fix the
eventuallyhelper function.Testing