Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): delete elasticache resources in After call #3957

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 15, 2022

Issue

Refs: #3948

Description

Moves deletion of elasticache resources in After call

Testing

No easy way to simulate failed test. The After call was tested in #3948

Success case
$ aws elasticache describe-cache-parameter-groups | jq '.CacheParameterGroups[].CacheParameterGroupName | select(startswith("aws-js-sdk"))'

$ yarn run cucumber-js --fail-fast -t @elasticache                   
yarn run v1.22.19
$ /local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/.bin/cucumber-js --fail-fast -t @elasticache
..............

2 scenarios (2 passed)
8 steps (8 passed)
0m00.345s (executing steps: 0m00.302s)
Done in 1.13s.

$ aws elasticache describe-cache-parameter-groups | jq '.CacheParameterGroups[].CacheParameterGroupName | select(startswith("aws-js-sdk"))'

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review September 15, 2022 17:06
@trivikr trivikr requested a review from a team as a code owner September 15, 2022 17:06
@trivikr trivikr merged commit 8c3e174 into aws:main Sep 15, 2022
@trivikr trivikr deleted the elasticache-delete-after branch September 15, 2022 19:31
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants