Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standardize plugins #422

Merged
merged 20 commits into from
Oct 29, 2019

Conversation

AllanZhengYP
Copy link
Contributor

Standardizes naming of plugins. continue to #402

/cc @srchase

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@codecov-io

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review October 28, 2019 18:03
@AllanZhengYP AllanZhengYP changed the title Standardize Plugins[WIP] Standardize Plugins Oct 28, 2019
@AllanZhengYP AllanZhengYP changed the title Standardize Plugins feat: standardize plugins Oct 28, 2019
@AllanZhengYP AllanZhengYP added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Oct 28, 2019
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions from first pass

clients/client-rds-data/README.md Outdated Show resolved Hide resolved
clients/client-rds-data/README.md Outdated Show resolved Hide resolved
clients/client-rds-data/README.md Outdated Show resolved Hide resolved
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/config-resolver/src/EndpointsConfig.ts Outdated Show resolved Hide resolved
Co-Authored-By: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP merged commit 6bd0469 into aws:smithy-codegen Oct 29, 2019
@lock
Copy link

lock bot commented Nov 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants