Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update input and resolved naming #444

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Nov 11, 2019

Brings naming of input and resolved config interfaces in line with smithy-lang/smithy-typescript@a5734d2

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Nov 11, 2019
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #444 into smithy-codegen will not change coverage.
The diff coverage is 60%.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen     #444   +/-   ##
===============================================
  Coverage           96.27%   96.27%           
===============================================
  Files                  72       72           
  Lines                1235     1235           
  Branches              223      223           
===============================================
  Hits                 1189     1189           
  Misses                 46       46
Impacted Files Coverage Δ
packages/middleware-retry/src/configurations.ts 100% <100%> (ø) ⬆️
packages/middleware-retry/src/retryMiddleware.ts 58.33% <50%> (ø) ⬆️
packages/middleware-signing/src/middleware.ts 75% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851c122...66fe007. Read the comment docs.

@srchase srchase merged commit 3c333fb into aws:smithy-codegen Nov 12, 2019
@srchase srchase deleted the config-naming branch November 12, 2019 18:41
@lock
Copy link

lock bot commented Nov 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants