Cannot find module '@smithy/abort-controller' in @aws-sdk/lib-storage@3.367.0

[WhiteKiwi]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

    Cannot find module '@smithy/abort-controller' from '../../node_modules/.pnpm/@aws-sdk+lib-storage@3.367.0_@aws-sdk+client-s3@3.367.0/node_modules/@aws-sdk/lib-storage/dist-cjs/Upload.js'

SDK version number

@aws-sdk/lib-storage@3.367.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v18.16.0

Reproduction Steps

Install and import '@aws-sdk/lib-storage@3.367.0'

Observed Behavior

Cannot find module '@smithy/abort-controller'

Expected Behavior

Find module '@smithy/abort-controller'

Possible Solution

Add '@smithy/abort-controller' in 'devDependencies' to the 'dependencies'

Additional Information/Context

No response

[yenfryherrerafeliz]

Hi @WhiteKiwi, sorry to hear about your issues. "@smithy/abort-controller" is indeed a dev dependency of @aws-sdk/lib-storage, which can be confirmed here. I am also not able to reproduce this issue on my end. Can you please make sure your dependencies are up to date?, could you please maybe try deleting the package-lock.json file?, and see if that fixes the problem.

Thanks!

[WhiteKiwi]

Hi!
I have confirmed that this issue is occurring only in pnpm.

First, devDependencies is not a dependency that is installed after the library is deployed.
For '@aws-sdk/lib-storage', it can be used as a phantom dependency at npm because it relies on '@smithy/abort-controller' in its sub-packages.
However, pnpm does not allow phantom dependencies, so only the dependencies specified in package.json's dependencies are accessible in the package.

You can reproduce it in the repo below.
https://github.com/WhiteKiwi/issues/tree/aws-sdk-js-v3/4942

I am not good at English. If there's anything you don't understand, please comment.
Thank you for reading it.

[yenfryherrerafeliz]

@WhiteKiwi thanks for this information. Your English is perfect, so do not worry. I will investigate this further and I will get back to you as soon as possible.

Thanks!

[saehun]

I've got same issue +1

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.