Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS_NODEJS_CONNECTION_REUSE_ENABLED doesn't exist in V3 #5883

Closed
perpil opened this issue Mar 13, 2024 · 2 comments
Closed

AWS_NODEJS_CONNECTION_REUSE_ENABLED doesn't exist in V3 #5883

perpil opened this issue Mar 13, 2024 · 2 comments
Assignees
Labels
bug This issue is a bug. documentation This is a problem with documentation. p2 This is a standard priority issue queued This issues is on the AWS team's backlog v2-v3-inconsistency Behavior has changed from v2 to v3, or feature is missing altogether

Comments

@perpil
Copy link

perpil commented Mar 13, 2024

Describe the issue

I'm researching an issue with the AWS_NODEJS_CONNECTION_REUSE_ENABLED env variable mentioned here. It appears to exist in V2 of the JavaScript SDK, but doesn't exist in the V3 sdk. When I grep my node_modules for that string, it doesn't exist when I use V3 clients (but does appear in the cdk).

❯ find . -type f | xargs grep -l AWS_NODEJS_CONNECTION_REUSE_ENABLED
./aws-cdk-lib/aws-lambda-nodejs/lib/function.d.ts
./aws-cdk-lib/aws-lambda-nodejs/lib/function.js
./aws-cdk/lib/index.js
./aws-cdk/lib/index.js.map
./aws-cdk/lib/api/aws-auth/sdk-provider.js

The only way of turning connection reuse off is to set the keepAlive: false in the Agent in V3. Can you confirm that AWS_NODEJS_CONNECTION_REUSE_ENABLED doesn't actually do anything in V3 and remove it from the documentation if so?

Links

Node Reusing Connections

@perpil perpil added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Mar 13, 2024
@RanVaknin RanVaknin self-assigned this Mar 13, 2024
@RanVaknin
Copy link
Contributor

Hi @perpil,

Thanks for your report. I can confirm that AWS_NODEJS_CONNECTION_REUSE_ENABLED does not exist in v3. We will remove this from the docs.

Good find.
Thanks again,
Ran~

@RanVaknin RanVaknin added bug This issue is a bug. p2 This is a standard priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Mar 13, 2024
@kuhe kuhe added the v2-v3-inconsistency Behavior has changed from v2 to v3, or feature is missing altogether label Mar 13, 2024
Copy link

github-actions bot commented Apr 2, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. documentation This is a problem with documentation. p2 This is a standard priority issue queued This issues is on the AWS team's backlog v2-v3-inconsistency Behavior has changed from v2 to v3, or feature is missing altogether
Projects
None yet
Development

No branches or pull requests

3 participants