Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass current package-version to typescript-codegen when running codegen #672

Closed
trivikr opened this issue Jan 7, 2020 · 2 comments
Closed
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Jan 7, 2020

Is your feature request related to a problem? Please describe.

Describe the solution you'd like
Pass the existing PACKAGE_VERSION when calling typescript-codegen

Describe alternatives you've considered
Have "1.0.0" as default versions for all packages, before lerna is run

@trivikr trivikr added the feature-request New feature or enhancement. May require GitHub community feedback. label Jan 7, 2020
@trivikr
Copy link
Member Author

trivikr commented Feb 11, 2020

Resolving as packageVersions are managed by lerna, and are not overridden by codegen

@trivikr trivikr closed this as completed Feb 11, 2020
@lock
Copy link

lock bot commented Feb 18, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

No branches or pull requests

1 participant