Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing middleware dep #736

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jan 15, 2020

Adds missing package.json entry for s3-control middleware dependency.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase requested a review from trivikr January 15, 2020 20:08
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 9cc9c4a into aws:smithy-codegen Jan 15, 2020
@codecov-io
Copy link

Codecov Report

Merging #736 into smithy-codegen will decrease coverage by 1.96%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           smithy-codegen     #736      +/-   ##
==================================================
- Coverage           94.54%   92.58%   -1.97%     
==================================================
  Files                  68      138      +70     
  Lines                1284     2684    +1400     
  Branches              256      463     +207     
==================================================
+ Hits                 1214     2485    +1271     
- Misses                 70      199     +129
Impacted Files Coverage Δ
packages/middleware-signing/src/middleware.ts 84.37% <0%> (-1.34%) ⬇️
...ackages/node-http-handler/src/node-http-handler.ts 100% <0%> (ø) ⬆️
packages/signature-v4/src/getCanonicalHeaders.ts 100% <0%> (ø) ⬆️
packages/signature-v4/src/suite.fixture.ts 100% <0%> (ø) ⬆️
...edential-provider-imds/src/fromInstanceMetadata.ts 100% <0%> (ø) ⬆️
packages/signature-v4/src/SignatureV4.ts 100% <0%> (ø) ⬆️
...dential-provider-imds/src/fromContainerMetadata.ts 100% <0%> (ø) ⬆️
packages/chunked-blob-reader/src/index.ts 100% <0%> (ø)
...s/middleware-bucket-endpoint/src/bucketHostname.ts 100% <0%> (ø)
packages/s3-request-presigner/src/constants.ts 100% <0%> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d60c59...4282637. Read the comment docs.

@lock
Copy link

lock bot commented Jan 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants