Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jest dependency in all packages to ^21 #87

Closed
jeskew opened this issue Dec 7, 2017 · 3 comments
Closed

Update Jest dependency in all packages to ^21 #87

jeskew opened this issue Dec 7, 2017 · 3 comments
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@jeskew
Copy link
Contributor

jeskew commented Dec 7, 2017

No description provided.

@trivikr
Copy link
Member

trivikr commented Dec 10, 2018

I tried to update jest in trivikr:update-jest
The test failures are documented in the commit trivikr@1ad0705

As of now, I've fixed couple of them:

Pending:

  • ReferenceError: defaultRegion is not defined
  • TypeError: Cannot read property 'byteLength' of undefined
  • No file coverage available
  • Your test suite must contain at least one test.

I'll find sometime next weekend to revisit fixing these tests.
If you do take a look at the commits - do comment on this issue on how to fix the remaining, or even better - push the fixes to trivikr:update-jest

@srchase srchase added the feature-request New feature or enhancement. May require GitHub community feedback. label Jan 15, 2019
@trivikr
Copy link
Member

trivikr commented May 21, 2019

Closing as we updated jest to v24 in #243

@trivikr trivikr closed this as completed May 21, 2019
@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

No branches or pull requests

3 participants