fix: codegen for using pure JS hasher in RN #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #998 +/- ##
===============================================
Coverage 91.36% 91.36%
===============================================
Files 144 144
Lines 2836 2836
Branches 501 501
===============================================
Hits 2591 2591
Misses 245 245Continue to review full report at Codecov.
|
trivikr
approved these changes
Mar 13, 2020
|
This looks good, only changes to react native components, to use the pure JS SHA implementation. |
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
The @aws-crypto/sha256-browser package doesn't work properly in ReactNative. So we use replace it will pure JS hasher(@aws-crypto/sha256-js) instead. Codegen for smithy-lang/smithy-typescript#144
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
The @aws-crypto/sha256-browser package doesn't work properly in ReactNative. So we use replace it will pure JS hasher(@aws-crypto/sha256-js) instead. Codegen for smithy-lang/smithy-typescript#144
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
The @aws-crypto/sha256-browser package doesn't work properly in ReactNative. So we use replace it will pure JS hasher(@aws-crypto/sha256-js) instead. Codegen for smithy-lang/smithy-typescript#144
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
The @aws-crypto/sha256-browser package doesn't work properly in ReactNative. So we use replace it will pure JS hasher(@aws-crypto/sha256-js) instead. Codegen for smithy-lang/smithy-typescript#144
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#929
Description of changes:
Codegen for smithy-lang/smithy-typescript#144.
The
@aws-crypto/sha256-browserpackage doesn't work properly in ReactNative. So we use replace it will pure JS hasher(@aws-crypto/sha256-js) instead.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.