Add support for request ID in all services.

This is a breaking change that renames the `response.data.RequestId`
property to `response.requestId`. To migrate your code, change:

    svc.operation(params, function (err, data) {
      console.log('Request ID:', data.RequestId);
    });

To the following:

    svc.operation(params, function () {
      console.log('Request ID:', this.requestId);
    });

Closes #215

Author: lsegal

lib/event_listeners.js

@@ -295,6 +295,13 @@ AWS.EventListeners = {
 
   }),
 
+  CorePost: new AWS.SequentialExecutor().addNamedListeners(function(add) {
+    add('EXTRACT_REQUEST_ID', 'extractData', function EXTRACT_REQUEST_ID(resp) {
+      resp.requestId = resp.httpResponse.headers['x-amz-request-id'] ||
+                       resp.httpResponse.headers['x-amzn-requestid'];
+    });
+  }),
+
   Logger: new AWS.SequentialExecutor().addNamedListeners(function(add) {
     add('LOG_REQUEST', 'complete', function LOG_REQUEST(resp) {
       var req = resp.request;

lib/response.js

@@ -61,22 +61,11 @@ var inherit = AWS.util.inherit;
  *     * retryable [Boolean] whether the error message is
  *       retryable.
  *
- * @!attribute service
+ * @!attribute requestId
  *   @readonly
- *   @!group Operation Properties
- *   @return [AWS.Service] The service object that initiated the request.
- *
- * @!attribute operation
- *   @readonly
- *   @!group Operation Properties
- *   @return [String] the name of the operation executed on
- *     the service.
- *
- * @!attribute params
- *   @readonly
- *   @!group Operation Properties
- *   @return [Object] the parameters sent in the request to
- *     the service.
+ *   @!group Data Properties
+ *   @return [String] the unique request ID associated with the response.
+ *     Log this value when debugging requests for AWS support.
  *
  * @!attribute retryCount
  *   @readonly

lib/service.js

@@ -199,8 +199,8 @@ AWS.Service = inherit({
    * @api private
    */
   addAllRequestListeners: function addAllRequestListeners(request) {
-    var list = [AWS.events, AWS.EventListeners.Core,
-                this.serviceInterface()];
+    var list = [AWS.events, AWS.EventListeners.Core, this.serviceInterface(),
+                AWS.EventListeners.CorePost];
     for (var i = 0; i < list.length; i++) {
       if (list[i]) request.addListeners(list[i]);
     }

lib/service_interface/rest_json.js

@@ -31,10 +31,6 @@ AWS.ServiceInterface.RestJson = {
       AWS.ServiceInterface.Json.extractData(resp);
       resp.data = AWS.util.merge(data, resp.data);
     }
-
-    // extract request id
-    resp.data.RequestId = resp.httpResponse.headers['x-amz-request-id'] ||
-                          resp.httpResponse.headers['x-amzn-requestid'];
   },
 
   populateBody: function populateBody(req) {

lib/service_interface/rest_xml.js

@@ -51,10 +51,6 @@ AWS.ServiceInterface.RestXml = {
       var parser = new AWS.XML.Parser(operation.output || {});
       AWS.util.update(resp.data, parser.parse(httpResponse.body.toString()));
     }
-
-    // extract request id
-    resp.data.RequestId = httpResponse.headers['x-amz-request-id'] ||
-                          httpResponse.headers['x-amzn-requestid'];
   },
 
   populateBody: function populateBody(req) {

test/services/s3.spec.coffee

@@ -245,8 +245,7 @@ describe 'AWS.S3', ->
                 Type: 'Group',
                 URI: 'uri'
             }
-          ],
-          RequestId : 'request-id'
+          ]
         })
 
   describe 'putBucketAcl', ->
@@ -324,8 +323,8 @@ describe 'AWS.S3', ->
           Bucket: 'Example-Bucket'
           Key: 'Example-Object'
           ETag: '"3858f62230ac3c915f300c664312c11f-9"'
-          RequestId: '656c76696e6727732072657175657374'
         })
+        expect(this.requestId).toEqual('656c76696e6727732072657175657374')
 
     it 'returns an error when the resp is 200 with an error xml document', ->
       body =
@@ -363,10 +362,8 @@ describe 'AWS.S3', ->
       helpers.mockHttpResponse 200, headers, body
       s3.getBucketLocation (error, data) ->
         expect(error).toBe(null)
-        expect(data).toEqual({
-          LocationConstraint: 'EU',
-          RequestId: 'abcxyz',
-        })
+        expect(data).toEqual(LocationConstraint: 'EU')
+        expect(this.requestId).toEqual('abcxyz')
 
   describe 'createBucket', ->
     it 'auto-populates the LocationConstraint based on the region', ->