fix S3 client no longer honor the computeChecksums config (#4052)

Author: AllanZhengYP

.changes/next-release/bugfix-S3-36a7ac77.json

@@ -0,0 +1,5 @@
+{
+  "type": "bugfix",
+  "category": "S3",
+  "description": "Fixed a bug that S3 client no longer honor the computeChecksums config introduced in #3799. Previously only the members with httpChecksumRequired trait will be disabled by unseting computeChecksums config. S3 doesn't not honor the config because it has its own logic handling MD5 chechsums."
+}

lib/services/s3.js

@@ -453,7 +453,8 @@ AWS.util.update(AWS.S3.prototype, {
   willComputeChecksums: function willComputeChecksums(req) {
     var rules = req.service.api.operations[req.operation].input.members;
     var body = req.httpRequest.body;
-    var needsContentMD5 = rules.ContentMD5 &&
+    var needsContentMD5 = req.service.config.computeChecksums &&
+      rules.ContentMD5 &&
       !req.params.ContentMD5 &&
       body &&
       (AWS.util.Buffer.isBuffer(req.httpRequest.body) || typeof req.httpRequest.body === 'string');

scripts/region-checker/allowlist.js

@@ -41,13 +41,13 @@ var allowlist = {
         262,
         275,
         281,
-        640,
-        642,
-        761,
-        772,
+        641,
+        643,
+        762,
         773,
         774,
-        779
+        775,
+        780,
     ]
 };
 

test/services/s3.spec.js

@@ -2544,6 +2544,27 @@ describe('AWS.S3', function() {
       }
     };
 
+    it('does not compute checksums if computeChecksums is off', function() {
+      willCompute('putObject', {
+        computeChecksums: false,
+        hash: null
+      });
+    });
+
+    it('does not compute checksums if computeChecksums is on and ContentMD5 is provided', function() {
+      willCompute('putBucketAcl', {
+        computeChecksums: true,
+        hash: '000'
+      });
+    });
+
+    it('computes checksums if computeChecksums is on and ContentMD5 is not provided', function() {
+      willCompute('putBucketAcl', {
+        computeChecksums: true,
+        hash: '1B2M2Y8AsgTpgAmY7PhCfg=='
+      });
+    });
+
     if (AWS.util.isNode()) {
       it('does not compute checksums for Stream objects', function() {
         s3 = new AWS.S3({