Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 Development: Sensible LangVersion #3316

Closed
2 tasks
danielmarbach opened this issue May 9, 2024 · 4 comments
Closed
2 tasks

V4 Development: Sensible LangVersion #3316

danielmarbach opened this issue May 9, 2024 · 4 comments
Labels
feature-request A feature should be added or improved. module/sdk-core p2 This is a standard priority issue v4

Comments

@danielmarbach
Copy link
Contributor

Describe the feature

Came up as a discussion point in #3293 (comment)

Use Case

At least make it possible to define static lambdas to avoid closure capturing.

Proposed Solution

Target LangVersion or higher

Azure SDK targets now LangVersion 11 Azure/azure-sdk-for-net#33890 even though they support net standard 2.0

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

v4

Targeted .NET Platform

All

Operating System and version

All

@danielmarbach danielmarbach added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 9, 2024
@ashishdhingra ashishdhingra added module/sdk-core needs-review v4 and removed needs-triage This issue or PR still needs to be triaged. needs-review labels May 9, 2024
@ashishdhingra ashishdhingra added the p2 This is a standard priority issue label Jun 17, 2024
@dscpinheiro
Copy link
Contributor

@danielmarbach I'm closing this since we're now using C# 11 for .NET 8 and C# 9 for the other TFMs (net472, netstandard2.0, and netcoreapp3.1).

I think that should be enough to use newer features, but please let us know if you have any other concerns.

Copy link

github-actions bot commented Jul 7, 2024

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@danielmarbach
Copy link
Contributor Author

danielmarbach commented Jul 7, 2024

@dscpinheiro
Is it worth the complexity of two lang versions? Why not have 11 across the board? You can shim/poly fill a lot (I already brought this up elsewhere) and for the very few things that requires runtime support you could add an analyzer or some other form of early capturing mechanism. Probably even a PR review checklist would do it.

@dscpinheiro
Copy link
Contributor

I can bring this up with Norm when he gets back from vacation. Like you said, I believe the concern was getting C# 11 to work with the .NET Framework (I don't think he had a chance to look at / make a decision on whether we're going to use Polyfill / PolySharp).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/sdk-core p2 This is a standard priority issue v4
Projects
None yet
Development

No branches or pull requests

3 participants