Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do I have to install openpyxl when I am using calamine as a pandas read_excel engine? #2695

Closed
jaanisfehling opened this issue Mar 1, 2024 · 2 comments · Fixed by #2696
Labels
question Further information is requested

Comments

@jaanisfehling
Copy link

jaanisfehling commented Mar 1, 2024

Example:
wr.s3.read_excel(file, sheet_name=0, engine="calamine")
Here I am using calamine as the engine to open an excel file. This is fully supported by pandas.
But, awswranger is throwing an error telling me that I have to install openpyxl, even tho I do not want to use it.
If I understand correctly, awswrangler is not using openpyxl but just delegating the call to pd.read_excel. If yes, why are you checking for this library? How can I know which engine is actually used?
If no, it would be better to let the user know that a different engine cannot be selected.

@jaanisfehling jaanisfehling added the question Further information is requested label Mar 1, 2024
@jaidisido jaidisido linked a pull request Mar 1, 2024 that will close this issue
@jaidisido
Copy link
Contributor

Thanks for raising this. I agree, not sure why openpyxl should be enforced

@jaanisfehling
Copy link
Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants