Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing functions in Aws\S3\StreamWrapper #2954

Open
1 of 2 tasks
p8nut opened this issue Jul 16, 2024 · 2 comments
Open
1 of 2 tasks

Missing functions in Aws\S3\StreamWrapper #2954

p8nut opened this issue Jul 16, 2024 · 2 comments
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue queued This issues is on the AWS team's backlog

Comments

@p8nut
Copy link

p8nut commented Jul 16, 2024

Describe the feature

Add the missing functions:

  • stream_set_option
  • stream_metadata
    to match fully implement the streamWrapper wlass

Use Case

As I Wrap a Stream in one of my project the interpreter complain about those two function missing.

Proposed Solution

In the php documentation, the two functions have the return value described as Returns true on success or false on failure. If option is not implemented, false should be returned. so we could simply implements the functions like that:

<?php

    public function stream_set_option($option, $arg1, $arg2)
    {
        return false;
    }

    public function stream_metadata($path, $option, $value)
    {
        return false;
    }

see https://www.php.net/manual/en/streamwrapper.stream-set-option.php
and https://www.php.net/manual/en/streamwrapper.stream-metadata.php

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

3.316.3

Environment details (Version of PHP (php -v)? OS name and version, etc.)

PHP 8.1.27

@p8nut p8nut added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 16, 2024
@RanVaknin RanVaknin added the p3 This is a minor priority issue label Jul 31, 2024
@p8nut
Copy link
Author

p8nut commented Aug 6, 2024

dont know if it was planned but it seems possible to implement file lock functions that are missing using the s3 object lock

but i have no idea if it's possible to native implement the truncate functions.

@RanVaknin RanVaknin self-assigned this Aug 26, 2024
@RanVaknin
Copy link
Contributor

Hi @p8nut ,

Thanks for the Feature request and PR. I think this is a valid request. We will have someone review.

All the best,
Ran~

@RanVaknin RanVaknin added queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Aug 26, 2024
@RanVaknin RanVaknin removed their assignment Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

2 participants