Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

EC2 describeInstanceTypes and describeInstanceTypeOfferings missing pagination config #8

Closed
sheldonkwok opened this issue Dec 4, 2019 · 4 comments
Assignees
Labels

Comments

@sheldonkwok
Copy link

describeInstanceTypes and describeInstanceTypeOfferings are missing pagination features. The ec2 paginators json does not have them referenced.

https://github.com/aws/aws-sdk-js/blob/master/apis/ec2-2016-11-15.paginators.json#L165

SDK version number
v2.584.0

@ajredniwja
Copy link

Hey @sheldonkwok , thank-you for reaching out to us with your issue.

I've marked this as a Feature Request. You're correct that the underlying describeInstanceTypes and describeInstanceTypeOfferings APIs supports pagination, but that the SDK currently does not. We'll need to review and work with the ec2 Service team to make this available in the SDK. Also as a work around you can look at the comment at aws/aws-sdk-js#939.

@sheldonkwok
Copy link
Author

In the mean time, I have imported the ec2 paginators file and monkey patched in

pagination.DescribeInstanceTypes = {
  input_token: 'NextToken',
  limit_key: 'MaxResults',
  output_token: 'NextToken',
  result_key: 'InstanceTypes',
};

pagination.DescribeInstanceTypeOfferings = {
  input_token: 'NextToken',
  limit_key: 'MaxResults',
  output_token: 'NextToken',
  result_key: 'InstanceTypeOfferings',
};

This has temporarily fixed my issue.

@ajredniwja ajredniwja transferred this issue from aws/aws-sdk-js Nov 6, 2020
@ajredniwja ajredniwja added feature-request New feature or request service-api This issue pertains to the AWS API labels Nov 7, 2020
@stobrien89 stobrien89 added ec2 and removed service-api This issue pertains to the AWS API labels Jul 26, 2021
@RanVaknin RanVaknin assigned aBurmeseDev and unassigned ajredniwja Mar 1, 2024
@tim-finnigan
Copy link
Contributor

The paginators have since been added, closing as resolved.

Copy link

github-actions bot commented Jul 3, 2024

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants