Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load secretsmanager.properties by context instead of system classloader #34

Closed
martinstrejc opened this issue Dec 10, 2019 · 3 comments
Closed

Comments

@martinstrejc
Copy link

The current implementation loads secretsmanager.properties configuration by system classloader. That's a big limitation, because in server implementations system classloader is usually a bootstrap, but not a current process. In case of Tomcat it is not possible to use secretsmanager.properties file to configure secretsmanager as a datasource because system classloader is aware of few system jars only, and no way to reconfigure.

@willtong1234
Copy link
Contributor

Thank you for your feedback. We have noted this as a feature request.

@willtong1234 willtong1234 added triage/needs-investigation and removed enhancement New feature or request labels May 26, 2021
@MoonJongMin
Copy link

Hi, I have a same problem that ClassLoader can't find secretsmanager.properties in war application. Considering there are so many applications running based WAR, this is a very waiting feature.

@jbct
Copy link

jbct commented Nov 7, 2022

Closing - this was merged with #32.

@jbct jbct closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants