Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No stop button (Ctrl + F2)? #2418

Closed
sdole opened this issue Feb 4, 2021 · 1 comment
Closed

No stop button (Ctrl + F2)? #2418

sdole opened this issue Feb 4, 2021 · 1 comment
Labels
bug We can reproduce the issue and confirmed it is a bug.

Comments

@sdole
Copy link

sdole commented Feb 4, 2021

Describe the bug
Developers must have ability to stop a lambda function execution with the red stop button or the Ctrl + F2 combination (default IntelliJ keystroke)
To reproduce
I hit Shift F9 key stroke on IDEA to debug the last lambda function that I wanted to. However, I had forgotten to start the docker service on my computer before doing so. There is no way to stop the sam build or attempted execution. Further, instead of failing gracefully, I just got an IDE error as follows:
I hit Shift F9 key stroke on IDEA to debug the last lambda function that I wanted to. However, I had forgotten to start the docker service on my computer before doing so.

Expected behavior
I should be able to stop by pressing a red stop button or the ctrl + F2 key stroke.
Screenshots
image

Your Environment

  • OS: Windows 10
  • JetBrains product: IntelliJ IDEA
  • JetBrains product version: latest
  • AWS Toolkit version: 1.23-203
  • SAM CLI version: latest
  • JVM/Python version: 3.8

Additional context

@sdole sdole added the bug We can reproduce the issue and confirmed it is a bug. label Feb 4, 2021
@sdole sdole changed the title No stop button (Ctrl + C)? No stop button (Ctrl + F2)? Feb 4, 2021
@abrooksv
Copy link
Contributor

abrooksv commented Feb 4, 2021

Thank you for this bug report. It looks like we have 2 issues:

  1. StepExecutor for SAM Build in the Build tool window lacks stop button.
  2. The Docker validate is throwing the wrong type of exception, it needs to be an ExecutionException (or at least caught and remapped to it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We can reproduce the issue and confirmed it is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants