Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: failing CodeCatalyst E2E test: updateDevEnvironment causes InternalException #3339

Open
justinmk3 opened this issue Apr 17, 2023 · 6 comments

Comments

@justinmk3
Copy link
Contributor

justinmk3 commented Apr 17, 2023

Problem

CC e2e tests failing on 61bbc24

  1) Test how this codebase uses the CodeCatalyst API
       Dev Environment functionality
         connects to a running Dev Environment:
     Error: Dev Environment failed to start (FAILED): test-alias-16817597…
      at /codebuild/output/src753672424/src/github.com/aws/aws-toolkit-vscode/src/shared/clients/codecatalystClient.ts:534:27
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

  2) Test how this codebase uses the CodeCatalyst API
       Dev Environment functionality
         stops a running Dev Environment, then starts it up again:
     Error: Dev env 8c7c9a6c-4ed4-4b5c-8626-33024bc7b708 did not transition to one of the following statuses before timeout: "RUNNING"
      at backend_1 (src/testE2E/codecatalyst/client.test.ts:528:23)
      at Generator.next (<anonymous>)
      at fulfilled (src/testE2E/codecatalyst/client.test.ts:9:58)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

  3) Test how this codebase uses the CodeCatalyst API
       Dev Environment functionality
         updates the properties of an existing dev environment:
     InternalException: An internal error has occurred while processing your request

Full build log

Solution

  • ✅ does it need to be reported to the service team?
  • is it a false positive? can the test harness make this clearer (by reporting relevant info, but not too much info, in the logs), or guard against it?
  • print the related request-id with the failure?
@JadenSimon
Copy link
Contributor

InternalException: An internal error has occurred while processing your request

This is possibly a backend regression with updateDevEnvironment

@justinmk3 justinmk3 changed the title CI: failing CodeCatalyst E2E test CI: failing CodeCatalyst E2E test: updateDevEnvironment causes InternalException Apr 18, 2023
@justinmk3
Copy link
Contributor Author

Also noticed that during successful CC e2e test run, logs show AccessDeniedException for GetDevEnvironment and DeleteDevEnvironment. Looks like this is expected because it's cleanup code in a before/after block. Ideally, we would not log expected errors in the build log.

2023-04-17 15:36:17 [ERROR]: API request failed: getDevEnvironment
params: {
  spaceName: 'aws-toolkits-test-space',
  projectName: 'aws-toolkit-integ-test-project-isolated',
  id: '801f2b15-10d9-41e8-a1c9-a9ff19846dac'
}
error: {
  message: "You don't have permission to perform this operation: GetDevEnvironment",
  code: 'AccessDeniedException',
  time: 2023-04-17T15:36:17.136Z,
  statusCode: 403,
  retryable: false,
  retryDelay: 33.69996626932179
}
headers: {
  'x-amz-apigw-id': undefined,
  'x-amz-cf-id': '-MTWdn4TIlcKMr_U2nM9DSMZG8JVCsIeio7VBzwoXUqXvhp8e5H-JA==',
  'x-amz-cf-pop': 'HIO52-P1',
  'x-amzn-remapped-content-length': undefined,
  'x-amzn-remapped-x-amzn-requestid': undefined,
  'x-amzn-requestid': '51dba5dc-f783-4d63-86d4-95e9b53ac1c0',
  'x-amzn-served-from': 'us-west-2',
  'x-amzn-trace-id': undefined,
  'x-cache': 'Error from cloudfront',
  'x-request-id': undefined
}

@justinmk3
Copy link
Contributor Author

Also noticed that during successful CC e2e test run, logs show AccessDeniedException for GetDevEnvironment and DeleteDevEnvironment. Looks like this is expected because it's cleanup code in a before/after block. Ideally, we would not log expected errors in the build log.

#3357

@justinmk3
Copy link
Contributor Author

All E2E jobs are now failing because of throttling:

  1) Test how this codebase uses the CodeCatalyst API
       Dev Environment functionality
         creates multiple dev envs, lists them, then deletes them:
     ThrottlingException: The request was denied due to request throttling.

  2) Test how this codebase uses the CodeCatalyst API
       Dev Environment functionality
         "after all" hook for "lists all projects for the given user":
     ThrottlingException: The request was denied due to request throttling.

@justinmk3
Copy link
Contributor Author

justinmk3 commented Sep 13, 2023

print the related request-id with the failure?

Not needed since the dev env id is printed and that's enough for troubleshooting.

e2e tests were reenabled in #3827 and are passing now.

@justinmk3 justinmk3 reopened this Sep 14, 2023
@justinmk3
Copy link
Contributor Author

Getting throttled again on mainline. c1005e9 c552091

  11 passing (3m)
  3 failing
  1) Test how this codebase uses the CodeCatalyst API
       Dev Environment functionality
         creates a Dev Environment with a different instance type + storage:
     ThrottlingException: The request was denied due to request throttling.

  2) Test how this codebase uses the CodeCatalyst API
       Dev Environment functionality
         creates multiple dev envs, lists them, then deletes them:
     ThrottlingException: The request was denied due to request throttling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants