Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EKS] [request]: allow to change configuration on vpc-cni addon #1333

Closed
fasher opened this issue Apr 8, 2021 · 14 comments
Closed

[EKS] [request]: allow to change configuration on vpc-cni addon #1333

fasher opened this issue Apr 8, 2021 · 14 comments
Labels
EKS Add-Ons EKS Networking EKS Networking related issues EKS Amazon Elastic Kubernetes Service Proposed Community submitted issue

Comments

@fasher
Copy link

fasher commented Apr 8, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request
Adding vpc-cni as a managed add-on is very nice. however right now you cannot change any configuration through it.
for example: to set AWS_VPC_K8S_CNI_EXTERNALSNAT I have to modify aws-node daemonset.
it would be nice if this can be controlled through the add-on

Which service(s) is this request for?
EKS

Are you currently working around this issue?
Yes

@fasher fasher added the Proposed Community submitted issue label Apr 8, 2021
@mikestef9 mikestef9 added the EKS Amazon Elastic Kubernetes Service label Apr 8, 2021
@mveitas
Copy link

mveitas commented Apr 18, 2021

What sort of configuration are we going to be able to set? For example, we are starting to require that all workloads running in a cluster specify resource values for cpu and memory. Is this something that will be included?

@kishoregv
Copy link

It would be nice if we can set labels and annotations

@chrissng
Copy link

chrissng commented Jun 2, 2021

Able to customize warm_ip_target and/or minimum_ip_target would be useful.

@jbilliau-rcd
Copy link

Agreed; I don't want to manage the CNI lifecycle myself, but that's my only option if i want to control WARM_IP_TARGET and MINIMUM_IP_TARGET, which the defaults take up a LOT of IP's from the VPC.

@liammurray
Copy link

Also would be useful for enabling SG for pods (which I do currently via separate k8s patch step)

@jwenz723
Copy link

I would love to see the ability to enable/configure Custom Networking using the vpc-cni addon.

Not sure if that would be handled by this issue or by #867

@sriramranganathan
Copy link

Amazon EKS team recently announced the general availability of advanced configuration feature for managed add-ons. You can now pass in advanced configuration for cluster add-ons, enabling you to customize add-on properties not handled by default settings. Configuration can be applied to add-ons either during cluster creation or at any time after the cluster is created.

Custom configuration will also allow you to set AWS_VPC_K8S_CNI_EXTERNALSNAT environment variable for the Amazon VPC CNI add-on.

To learn more about this feature, check out this blogpost - https://aws.amazon.com/blogs/containers/amazon-eks-add-ons-advanced-configuration/

Check out the Amazon EKS documentation - https://docs.aws.amazon.com/eks/latest/userguide/managing-add-ons.html

@miranda-delfiacco
Copy link

Thank you for adding this feature, is there any chance WARM_IP_TARGET will be a configurable option in the future or should I open a new request for that?

@mikestef9
Copy link
Contributor

mikestef9 commented Jan 4, 2023

That's coming soon with v1.12.0-eksbuild.2

@jdn5126
Copy link

jdn5126 commented Jun 6, 2023

Just wanted to update here that in v1.13.0-eksbuild.1, you will also be able to configure tolerations, affinity, liveness and readiness probe timeouts, and ENIConfigs

@avnerv
Copy link

avnerv commented Nov 28, 2023

what about annotations and labels?

@jdn5126
Copy link

jdn5126 commented Nov 28, 2023

Pod labels and pod annotations are not currently configurable via EKS managed addons. I have made a note to add these for future versions

@jdn5126
Copy link

jdn5126 commented Dec 14, 2023

Configuring additional pod labels and pod annotations via EKS managed addons will ship with VPC CNI v1.15.5, for which the release is currently in progress

@avnerv
Copy link

avnerv commented Jan 30, 2024

jfyi, for v1.16.0 is working, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EKS Add-Ons EKS Networking EKS Networking related issues EKS Amazon Elastic Kubernetes Service Proposed Community submitted issue
Projects
None yet
Development

No branches or pull requests