Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECS] [request]: Support log driver fluentd-buffer-limit option in FireLens #1484

Closed
zhonghui12 opened this issue Aug 23, 2021 · 3 comments
Closed
Assignees
Labels
Coming Soon ECS Amazon Elastic Container Service Proposed Community submitted issue

Comments

@zhonghui12
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request
FireLens uses the Fluentd docker log driver to send logs from the container to Fluent Bit/Fluentd. Some of our customers found that under high throughput, the default buffer inside of Docker could run out of memory. We could add an option like log-driver-buffer-limit which would set the fluentd-buffer-limit field.

Which service(s) is this request for?
ECS EC2, and ECS Fargate

Additional context
The feature is already released in ECS EC2: https://github.com/aws/amazon-ecs-agent/releases/tag/v1.55.0 and will be supported in ECS Fargate soon.

@zhonghui12 zhonghui12 added the Proposed Community submitted issue label Aug 23, 2021
@zhonghui12
Copy link
Author

Note:

This feature is different for #964 because this would provide a way for customers to configure options in fluentd log driver. But #964 aims to work on a fluent bit config option.

@zhonghui12
Copy link
Author

This feature has been launched and fully supported in ECS EC2 and ECS fargate now: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/using_firelens.html#firelens-docker-buffer-limit.

@lucasgadams
Copy link

Is something like this supported for fluent bit as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coming Soon ECS Amazon Elastic Container Service Proposed Community submitted issue
Projects
None yet
Development

No branches or pull requests

3 participants