refactor: move "templates" pkg under "internal/pkg/template" pkg (#2691)

To start using the new ✨ [embed pkg](https://pkg.go.dev/embed) and deprecate our use of packr we need to move all of our templates under the `internal/pkg/template` pkg. This is because unfortunately we can't refer to the current "templates" directory by doing `"../../../templates"`:

> Because embed.Files implements fs.FS, it cannot provide access to files with names beginning with .., so files in parent directories are also disallowed entirely, even when the parent directory named by .. does happen to be in the same module.
>
> golang/go#46056 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Author: efekarakus

Makefile

@@ -3,9 +3,11 @@
 
 BINARY_NAME=copilot
 PACKAGES=./internal...
-SOURCE_CUSTOM_RESOURCES=${PWD}/cf-custom-resources
-BUILT_CUSTOM_RESOURCES=${PWD}/templates/custom-resources
-GOBIN=${PWD}/bin/tools
+ROOT_SRC_DIR=${PWD}
+SOURCE_CUSTOM_RESOURCES=${ROOT_SRC_DIR}/cf-custom-resources
+TEMPLATES_DIR=${ROOT_SRC_DIR}/internal/pkg/template/templates
+BUILT_CUSTOM_RESOURCES=${TEMPLATES_DIR}/custom-resources
+GOBIN=${ROOT_SRC_DIR}/bin/tools
 COVERAGE=coverage.out
 
 DESTINATION=./bin/local/${BINARY_NAME}
@@ -63,9 +65,9 @@ packr-build: tools package-custom-resources
 .PHONY: packr-clean
 packr-clean: tools package-custom-resources-clean
 	@echo "Cleaning up static files generated code" &&\
-	cd templates &&\
+	cd ${TEMPLATES_DIR} &&\
 	${GOBIN}/packr2 clean &&\
-	cd ..\
+	cd ${ROOT_SRC_DIR} \
 
 .PHONY: test
 test: packr-build run-unit-test custom-resource-tests packr-clean
@@ -75,7 +77,7 @@ custom-resource-tests:
 	@echo "Running custom resource unit tests" &&\
 	cd ${SOURCE_CUSTOM_RESOURCES} &&\
 	npm test &&\
-	cd ..
+	cd ${ROOT_SRC_DIR}
 
 # Minifies the resources in cf-custom-resources/lib and copies
 # those minified assets into templates/custom-resources so that
@@ -85,7 +87,7 @@ package-custom-resources:
 	@echo "Packaging custom resources to templates/custom-resources" &&\
 	cd ${SOURCE_CUSTOM_RESOURCES} &&\
 	npm run package &&\
-	cd ..
+	cd ${ROOT_SRC_DIR}
 
 # We only need the minified custom resources during building. After
 # they're packed, we can remove them.

cf-custom-resources/package.json

@@ -13,7 +13,7 @@
     "lint": "eslint lib",
     "build+test+package": "npm run build+test",
     "build+test": "npm run build && npm test",
-    "package": "minify lib -d ../templates/custom-resources --builtIns false"
+    "package": "minify lib -d ../internal/pkg/template/templates/custom-resources --builtIns false"
   },
   "keywords": [],
   "author": {

internal/pkg/deploy/cloudformation/app_test.go

@@ -17,8 +17,6 @@ import (
 	"github.com/aws/copilot-cli/internal/pkg/deploy"
 	"github.com/aws/copilot-cli/internal/pkg/deploy/cloudformation/mocks"
 	"github.com/aws/copilot-cli/internal/pkg/deploy/cloudformation/stack"
-	"github.com/aws/copilot-cli/templates"
-	"github.com/gobuffalo/packd"
 	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/require"
 	"gopkg.in/yaml.v3"
@@ -100,7 +98,6 @@ func TestCloudFormation_DeployApp(t *testing.T) {
 			cf := CloudFormation{
 				cfnClient:   tc.mockStack(ctrl),
 				appStackSet: tc.mockStackSet(t, ctrl),
-				box:         templates.Box(),
 				region:      tc.region,
 			}
 
@@ -343,7 +340,6 @@ func TestCloudFormation_AddEnvToApp(t *testing.T) {
 			defer ctrl.Finish()
 			cf := CloudFormation{
 				appStackSet: tc.mockStackSet(t, ctrl),
-				box:         templates.Box(),
 				region:      "us-west-2",
 			}
 			got := cf.AddEnvToApp(&AddEnvToAppOpts{
@@ -411,7 +407,6 @@ func TestCloudFormation_AddPipelineResourcesToApp(t *testing.T) {
 			defer ctrl.Finish()
 			cf := CloudFormation{
 				appStackSet: tc.mockStackSet(t, ctrl),
-				box:         templates.Box(),
 			}
 			getRegionFromClient = tc.getRegionFromClient
 
@@ -512,7 +507,6 @@ func TestCloudFormation_AddServiceToApp(t *testing.T) {
 			defer ctrl.Finish()
 			cf := CloudFormation{
 				appStackSet: tc.mockStackSet(t, ctrl),
-				box:         templates.Box(),
 				region:      "us-west-2",
 			}
 
@@ -571,7 +565,6 @@ func TestCloudFormation_RemoveServiceFromApp(t *testing.T) {
 			defer ctrl.Finish()
 			cf := CloudFormation{
 				appStackSet: tc.mockStackSet(t, ctrl),
-				box:         templates.Box(),
 				region:      "us-west-2",
 			}
 
@@ -662,7 +655,6 @@ func TestCloudFormation_GetRegionalAppResources(t *testing.T) {
 					return tc.createRegionalMockClient(ctrl)
 				},
 				appStackSet: tc.mockStackSet(t, ctrl),
-				box:         packd.NewMemoryBox(),
 			}
 
 			// WHEN
@@ -748,7 +740,6 @@ func TestCloudFormation_GetAppResourcesByRegion(t *testing.T) {
 					return tc.createRegionalMockClient(ctrl)
 				},
 				appStackSet: tc.mockStackSet(t, ctrl),
-				box:         packd.NewMemoryBox(),
 			}
 
 			// WHEN
@@ -844,7 +835,6 @@ func TestCloudFormation_DelegateDNSPermissions(t *testing.T) {
 			defer ctrl.Finish()
 			cf := CloudFormation{
 				cfnClient: tc.createMock(ctrl),
-				box:       templates.Box(),
 			}
 
 			// WHEN

internal/pkg/deploy/cloudformation/cloudformation.go

@@ -28,8 +28,6 @@ import (
 	"github.com/aws/copilot-cli/internal/pkg/stream"
 	"github.com/aws/copilot-cli/internal/pkg/term/log"
 	"github.com/aws/copilot-cli/internal/pkg/term/progress"
-	"github.com/aws/copilot-cli/templates"
-	"github.com/gobuffalo/packd"
 	"golang.org/x/sync/errgroup"
 )
 
@@ -108,7 +106,6 @@ type CloudFormation struct {
 	ecsClient      ecsClient
 	regionalClient func(region string) cfnClient
 	appStackSet    stackSetClient
-	box            packd.Box
 	s3Client       s3Client
 	region         string
 }
@@ -126,7 +123,6 @@ func New(sess *session.Session) CloudFormation {
 			}))
 		},
 		appStackSet: stackset.New(sess),
-		box:         templates.Box(),
 		s3Client:    s3.New(sess),
 		region:      aws.StringValue(sess.Config.Region),
 	}

internal/pkg/template/template.go

@@ -13,7 +13,7 @@ import (
 	"text/template"
 
 	"github.com/aws/copilot-cli/internal/pkg/aws/s3"
-	"github.com/aws/copilot-cli/templates"
+	"github.com/aws/copilot-cli/internal/pkg/template/templates"
 	"github.com/gobuffalo/packd"
 )