Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate EKSA_VSPHERE_* Env Var Validation #3071

Open
jonathanmeier5 opened this issue Aug 19, 2022 · 0 comments
Open

Consolidate EKSA_VSPHERE_* Env Var Validation #3071

jonathanmeier5 opened this issue Aug 19, 2022 · 0 comments
Labels
area/providers/vsphere vSphere provider related issues or feature requests kind/cleanup team/cli
Milestone

Comments

@jonathanmeier5
Copy link
Member

We currently validate EKSA_VSPHERE_* variables in two places: here and here.

We should consolidate this validation logic.

@g-gaston and I were talking recently about the fact that a lot of code pulls data from the environment, treating it as a defacto global state object. We should think about pushing that state into config objects instead. We can then run validations on the config objects as they are created.

@jonathanmeier5 jonathanmeier5 added kind/cleanup team/cli area/providers/vsphere vSphere provider related issues or feature requests labels Aug 19, 2022
@jonathanmeier5 jonathanmeier5 added this to the backlog milestone Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/providers/vsphere vSphere provider related issues or feature requests kind/cleanup team/cli
Projects
None yet
Development

No branches or pull requests

1 participant