Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate PodDisruptionBudget in preflight check #5189

Closed
jiayiwang7 opened this issue Mar 7, 2023 · 1 comment
Closed

Validate PodDisruptionBudget in preflight check #5189

jiayiwang7 opened this issue Mar 7, 2023 · 1 comment
Assignees
Milestone

Comments

@jiayiwang7
Copy link
Member

No description provided.

@jiayiwang7 jiayiwang7 changed the title Validate PodDisruptionBudget as preflight check for upgrade Validate PodDisruptionBudget in preflight check Mar 9, 2023
@vignesh-goutham
Copy link
Member

Pod disruptions budgets are a way to stop pods from getting disrupted from voluntary actions like draining nodes, etc. A pdb depends on how the application is designed and how much it can tolerate. A very strict pdb that doesnt allow even a single node to drain is problematic and will not let operations like upgrade succeed.

Proposed EKS-A changes:

  1. In pre-flights, check if there is a pdb set on the target cluster, and if there is, throw a warning.
  2. If any pdb is very strict, (allows 0 disruptions), throw an error and fail upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants