Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github PAT Validation regex does not handle new PAT format #5764

Closed
thunderboltsid opened this issue May 2, 2023 · 1 comment · Fixed by #5769
Closed

Github PAT Validation regex does not handle new PAT format #5764

thunderboltsid opened this issue May 2, 2023 · 1 comment · Fixed by #5769
Assignees
Milestone

Comments

@thunderboltsid
Copy link
Contributor

thunderboltsid commented May 2, 2023

While trying out the EKS-A flux setup docs, I came across a bug. Non-classic Github PATs that allow fine-grained repo-scope tokens are rejected by the current validation scheme in EKS-A

github access token environment variable EKSA_GITHUB_TOKEN is invalid; must match format ^[A-Za-z0-9_]{40}$

This is happening due to the validation expecting the PAT to match against a specific regex which it doesn't.

Here's an example of a PAT that can fail:

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
@abhay-krishna
Copy link
Member

abhay-krishna commented May 2, 2023

Thanks for reporting the bug @thunderboltsid! We are working on a fix and this should be resolved in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants